some detail changes to do with -w flags etc

[spider.git] / perl / DXLog.pm

diff --git a/perl/DXLog.pm b/perl/DXLog.pm
index e4f228035194c42dea45ab9b9129c5e5f7666e6c..dde723027f5b237afd735c4452eeafd1b7a42a02 100644 (file)
--- a/perl/DXLog.pm
+++ b/perl/DXLog.pm
@@ -37,7 +37,6 @@ use Julian;
 use Carp;
 
 use strict;
-
 use vars qw($log);
 
 $log = new('log', 'dat', 'm');
@@ -51,7 +50,7 @@ sub new
        my $ref = {};
        $ref->{prefix} = "$main::data/$prefix";
        $ref->{suffix} = $suffix if $suffix;
-       $ref->{sort} = $sort;
+       $ref->{'sort'} = $sort;
                
        # make sure the directory exists
        mkdir($ref->{prefix}, 0777) if ! -e $ref->{prefix};
@@ -67,16 +66,15 @@ sub open
        if (defined $mode) {
                my $dir = "$self->{prefix}/$year";
                mkdir($dir, 0777) if ! -e $dir;
-               $self->{mode} = $mode;
-       } else {
-               delete $self->{mode};
        }
        
-       $self->{fn} = sprintf "$self->{prefix}/$year/%02d", $thing if $self->{sort} eq 'm';
-       $self->{fn} = sprintf "$self->{prefix}/$year/%03d", $thing if $self->{sort} eq 'd';
+       $self->{fn} = sprintf "$self->{prefix}/$year/%02d", $thing if $self->{'sort'} eq 'm';
+       $self->{fn} = sprintf "$self->{prefix}/$year/%03d", $thing if $self->{'sort'} eq 'd';
        $self->{fn} .= ".$self->{suffix}" if $self->{suffix};
        
        $mode = 'r' if !$mode;
+       $self->{mode} = $mode;
+       
        my $fh = new FileHandle $self->{fn}, $mode;
        return undef if !$fh;
        $fh->autoflush(1) if $mode ne 'r'; # make it autoflushing if writable
@@ -94,9 +92,9 @@ sub open
 sub openprev
 {
        my $self = shift;
-       if ($self->{sort} eq 'm') {
+       if ($self->{'sort'} eq 'm') {
                ($self->{year}, $self->{thing}) = Julian::subm($self->{year}, $self->{thing}, 1);
-       } elsif ($self->{sort} eq 'd') {
+       } elsif ($self->{'sort'} eq 'd') {
                ($self->{year}, $self->{thing}) = Julian::sub($self->{year}, $self->{thing}, 1);
        }
        return $self->open($self->{year}, $self->{thing}, @_);
@@ -106,9 +104,9 @@ sub openprev
 sub opennext
 {
        my $self = shift;
-       if ($self->{sort} eq 'm') {
+       if ($self->{'sort'} eq 'm') {
                ($self->{year}, $self->{thing}) = Julian::addm($self->{year}, $self->{thing}, 1);
-       } elsif ($self->{sort} eq 'd') {
+       } elsif ($self->{'sort'} eq 'd') {
                ($self->{year}, $self->{thing}) = Julian::add($self->{year}, $self->{thing}, 1);
        }
        return $self->open($self->{year}, $self->{thing}, @_);
@@ -119,9 +117,9 @@ sub unixtoj
 {
        my $self = shift;
        
-       if ($self->{sort} eq 'm') {
+       if ($self->{'sort'} eq 'm') {
                return Julian::unixtojm(shift);
-       } elsif ($self->{sort} eq 'd') {
+       } elsif ($self->{'sort'} eq 'd') {
                return Julian::unixtoj(shift);
        }
        confess "shouldn't get here";
@@ -164,7 +162,6 @@ sub close
        my $self = shift;
        undef $self->{fh};                      # close the filehandle
        delete $self->{fh};
-       delete $self->{mode};
 }
 
 # log something in the system log 
@@ -177,7 +174,7 @@ sub Log
        $log->writeunix($t, join('^', $t, @_) );
 }
 
-sub DESTROY                                            # catch undefs and do what is required further do the tree
+sub DESTROY                                            # catch undefs and do what is required further down the tree
 {
        my $self = shift;
        DXDebug::dbg("dxlog", "closing $self->{fn}\n");