do some more rigorous checking of PC9x sentences
[spider.git] / perl / DXProtHandle.pm
index 9e0f5ec4adb111ccf81f159a6368049cce558926..6b8a4cd8e00dfe3063759c05d085b4e585f44e3b 100644 (file)
@@ -44,14 +44,15 @@ use vars qw($pc11_max_age $pc23_max_age $last_pc50 $eph_restime $eph_info_restim
                        %nodehops $baddx $badspotter $badnode $censorpc
                        $allowzero $decode_dk0wcy $send_opernam @checklist
                        $eph_pc15_restime $pc9x_past_age $pc9x_future_age
-                       $pc10_dupe_age
+                       $pc10_dupe_age $pc92_slug_changes $last_pc92_slug
                   );
 
 $pc9x_past_age = 62*60;                        # maximum age in the past of a px9x (a config record might be the only
                                                                # thing a node might send - once an hour)
 $pc9x_future_age = 5*60;               # maximum age in the future ditto
 $pc10_dupe_age = 45;                   # just something to catch duplicate PC10->PC93 conversions
-
+$pc92_slug_changes = 60;               # slug any changes going outward for this long
+$last_pc92_slug = 0;                   # the last time we sent out any delayed add or del PC92s
 
 # incoming talk commands
 sub handle_10
@@ -766,7 +767,7 @@ sub handle_19
 #              $self->route_pc21($self->{call}, $line, @rout);
                $self->route_pc19($self->{call}, $line, @rout);
        }
-       if (@pc92out) {
+       if (@pc92out && !$pc92_slug_changes) {
                $self->route_pc92a($main::mycall, $line, $main::routeroot, @pc92out) if $self->{state} eq 'normal';
        }
 }
@@ -1328,8 +1329,14 @@ sub _decode_pc92_call
        my $icall = shift;
        my @part = split /:/, $icall;
        my ($flag, $call) = unpack "A A*", $part[0];
-       return () unless defined $flag && $flag ge '0' && $flag le '7';
-       return () unless $call && is_callsign($call);
+       unless (defined $flag && $flag ge '0' && $flag le '7') {
+               dbg("PCPROT: $icall no flag byte (0-7) at front of call, ignored") if isdbg('chanerr');
+               return ();
+       }
+       unless ($call && is_callsign($call)) {
+               dbg("PCPROT: $icall no recognisable callsign, ignored") if isdbg('chanerr');
+               return ();
+       }
        my $is_node = $flag & 4;
        my $is_extnode = $flag & 2;
        my $here = $flag & 1;
@@ -1364,6 +1371,9 @@ sub _encode_pc92_call
        return "$flag$call$extra";
 }
 
+my %things_add;
+my %things_del;
+
 sub _add_thingy
 {
        my $parent = shift;
@@ -1379,6 +1389,10 @@ sub _add_thingy
                        dbg("ROUTE: added user $call to " . $parent->call) if isdbg('routelow');
                        @rout = $parent->add_user($call, Route::here($here));
                }
+               if ($pc92_slug_changes && $parent == $main::routeroot) {
+                       $things_add{$call} = Route::get($call);
+                       delete $things_del{$call};
+               }
        }
        return @rout;
 }
@@ -1390,19 +1404,40 @@ sub _del_thingy
        my ($call, $is_node, $is_extnode, $here, $version, $build) = @$s;
        my @rout;
        if ($call) {
+               my $ref;
                if ($is_node) {
-                       my $nref = Route::Node::get($call);
+                       $ref = Route::Node::get($call);
                        dbg("ROUTE: deleting node $call from " . $parent->call) if isdbg('routelow');
-                       @rout = $nref->del($parent) if $nref;
+                       @rout = $ref->del($parent) if $ref;
                } else {
-                       my $uref = Route::User::get($call);
+                       $ref = Route::User::get($call);
                        dbg("ROUTE: deleting user $call from " . $parent->call) if isdbg('routelow');
-                       @rout = $parent->del_user($uref) if $uref;
+                       @rout = $parent->del_user($ref) if $ref;
+               }
+               if ($pc92_slug_changes && $parent == $main::routeroot) {
+                       $things_del{$call} = $ref unless exists $things_add{$call};
+                       delete $things_add{$call};
                }
        }
        return @rout;
 }
 
+# this will only happen if we are slugging changes and
+# there are some changes to be sent, it will create an add or a delete
+# or both
+sub gen_pc92_changes
+{
+       my @add = values %things_add;
+       my @del = values %things_del;
+       return (\@add, \@del);
+}
+
+sub clear_pc92_changes
+{
+       %things_add = %things_del = ();
+       $last_pc92_slug = $main::systime;
+}
+
 my $_last_time;
 my $_last_occurs;
 
@@ -1469,10 +1504,6 @@ sub handle_92
        my (@radd, @rdel);
 
        my $pcall = $_[1];
-       unless ($pcall) {
-               dbg("PCPROT: invalid callsign string '$_[1]', ignored") if isdbg('chanerr');
-               return;
-       }
        my $t = $_[2];
        my $sort = $_[3];
 
@@ -1555,7 +1586,18 @@ sub handle_92
                # this is the main route section
                # here is where all the routes are created and destroyed
 
-               my @ent = map {[ _decode_pc92_call($_) ]} grep {$_ && /^[0-7]/} @_[4 .. $#_];
+               # cope with missing duplicate node calls in the first slot for A or D
+               my $me = $_[4] || '';
+               if (($sort eq 'A' || $sort eq 'D')) {
+                       $me ||= _encode_pc92_call($parent) if !$me ;
+               } else {
+                       unless ($me) {
+                               dbg("PCPROT: this type of PC92 *must* have a node call in the first slot, ignored") if is_dbg('chanerr');
+                               return;
+                       }
+               }
+
+               my @ent = map {[ _decode_pc92_call($_) ]} grep {$_ && /^[0-7]/} $me, @_[5 .. $#_];
 
                if (@ent) {
 
@@ -1564,50 +1606,43 @@ sub handle_92
                        # otherwise use the node call and update any information
                        # that needs to be done.
                        my ($call, $is_node, $is_extnode, $here, $version, $build) = @{$ent[0]};
-                       if (($sort eq 'A' || $sort eq 'D') && !$is_node) {
-                               # parent is already set correctly
-                               # this is to allow shortcuts for A and D records
-                               # not repeating the origin call to no real purpose
-                               ;
-                       } else {
-                               if ($call && $is_node) {
-                                       if ($call eq $main::mycall) {
-                                               dbg("PCPROT: $call looped back onto $main::mycall, ignored") if isdbg('chanerr');
-                                               return;
-                                       }
-                                       # this is only accepted from my "self".
-                                       # this also kills configs from PC92 nodes with external PC19 nodes that are also
-                                       # locally connected. Local nodes always take precedence.
-                                       if (DXChannel::get($call) && $call ne $self->{call}) {
-                                               dbg("PCPROT: locally connected node $call from other another node $self->{call}, ignored") if isdbg('chanerr');
-                                               return;
-                                       }
-                                       if ($is_extnode) {
-                                               # reparent to external node (note that we must have received a 'C' or 'A' record
-                                               # from the true parent node for this external before we get one for the this node
-                                               unless ($parent = Route::Node::get($call)) {
-                                                       if ($is_extnode && $oparent) {
-                                                               @radd =  _add_thingy($oparent, $ent[0]);
-                                                               $parent = $radd[0];
-                                                       } else {
-                                                               dbg("PCPROT: no previous C or A for this external node received, ignored") if isdbg('chanerr');
-                                                               return;
-                                                       }
+                       if ($call && $is_node) {
+                               if ($call eq $main::mycall) {
+                                       dbg("PCPROT: $call looped back onto $main::mycall, ignored") if isdbg('chanerr');
+                                       return;
+                               }
+                               # this is only accepted from my "self".
+                               # this also kills configs from PC92 nodes with external PC19 nodes that are also
+                               # locally connected. Local nodes always take precedence.
+                               if (DXChannel::get($call) && $call ne $self->{call}) {
+                                       dbg("PCPROT: locally connected node $call from other another node $self->{call}, ignored") if isdbg('chanerr');
+                                       return;
+                               }
+                               if ($is_extnode) {
+                                       # reparent to external node (note that we must have received a 'C' or 'A' record
+                                       # from the true parent node for this external before we get one for the this node
+                                       unless ($parent = Route::Node::get($call)) {
+                                               if ($is_extnode && $oparent) {
+                                                       @radd =  _add_thingy($oparent, $ent[0]);
+                                                       $parent = $radd[0];
+                                               } else {
+                                                       dbg("PCPROT: no previous C or A for this external node received, ignored") if isdbg('chanerr');
+                                                       return;
                                                }
-                                               $parent = check_pc9x_t($call, $t, 92) || return;
-                                               $parent->via_pc92(1);
-                                               $parent->PC92C_dxchan($self->{call});
                                        }
-                               } else {
-                                       dbg("PCPROT: must be mycall or external node as first entry, ignored") if isdbg('chanerr');
-                                       return;
+                                       $parent = check_pc9x_t($call, $t, 92) || return;
+                                       $parent->via_pc92(1);
+                                       $parent->PC92C_dxchan($self->{call});
                                }
-                               $parent->here(Route::here($here));
-                               $parent->version($version) if $version && $version > $parent->version;
-                               $parent->build($build) if $build && $build > $parent->build;
-                               $parent->PC92C_dxchan($self->{call}) unless $self->{call} eq $parent->call;
-                               shift @ent;
+                       } else {
+                               dbg("PCPROT: must be \$mycall or external node as first entry, ignored") if isdbg('chanerr');
+                               return;
                        }
+                       $parent->here(Route::here($here));
+                       $parent->version($version) if $version && $version > $parent->version;
+                       $parent->build($build) if $build && $build > $parent->build;
+                       $parent->PC92C_dxchan($self->{call}) unless $self->{call} eq $parent->call;
+                       shift @ent;
                }
 
                # do a pass through removing any references to either locally connected nodes or mycall
@@ -1705,11 +1740,7 @@ sub handle_93
 
 #      $self->{do_pc9x} ||= 1;
 
-       my $pcall = $_[1];
-       unless (is_callsign($pcall)) {
-               dbg("PCPROT: invalid callsign string '$_[1]', ignored") if isdbg('chanerr');
-               return;
-       }
+       my $pcall = $_[1];                      # this is now checked earlier
 
        # remember that we are converting PC10->PC93 and self will be $main::me if it
        # comes from us