X-Git-Url: http://dxcluster.org/gitweb/gitweb.cgi?a=blobdiff_plain;f=perl%2FDXLog.pm;h=17559b36fe62577d2b53cef0c8f9f810d225c5ba;hb=d9db74c1b2b9b57cb6d31e8c8c425f3636f62f87;hp=c699413717534370ae4ab60536f75b1b8427931a;hpb=cce161221036760959ff1d0b7628a55942bf558a;p=spider.git diff --git a/perl/DXLog.pm b/perl/DXLog.pm index c6994137..17559b36 100644 --- a/perl/DXLog.pm +++ b/perl/DXLog.pm @@ -27,11 +27,11 @@ package DXLog; require Exporter; @ISA = qw(Exporter); -@EXPORT = qw(Log); +@EXPORT = qw(Log Logclose); -use FileHandle; +use IO::File; use DXVars; -use DXDebug (); +# use DXDebug (); use DXUtil; use Julian; use Carp; @@ -53,7 +53,7 @@ sub new $ref->{'sort'} = $sort; # make sure the directory exists - mkdir($ref->{prefix}, 0777) if ! -e $ref->{prefix}; + mkdir($ref->{prefix}, 0777) unless -e $ref->{prefix}; return bless $ref; } @@ -66,9 +66,6 @@ sub open if (defined $mode) { my $dir = "$self->{prefix}/$year"; mkdir($dir, 0777) if ! -e $dir; - $self->{mode} = $mode; - } else { - delete $self->{mode}; } $self->{fn} = sprintf "$self->{prefix}/$year/%02d", $thing if $self->{'sort'} eq 'm'; @@ -76,7 +73,9 @@ sub open $self->{fn} .= ".$self->{suffix}" if $self->{suffix}; $mode = 'r' if !$mode; - my $fh = new FileHandle $self->{fn}, $mode; + $self->{mode} = $mode; + + my $fh = new IO::File $self->{fn}, $mode, 0666; return undef if !$fh; $fh->autoflush(1) if $mode ne 'r'; # make it autoflushing if writable $self->{fh} = $fh; @@ -84,7 +83,7 @@ sub open $self->{year} = $year; $self->{thing} = $thing; - DXDebug::dbg("dxlog", "opening $self->{fn}\n"); +# DXDebug::dbg("dxlog", "opening $self->{fn}\n"); return $self->{fh}; } @@ -162,8 +161,14 @@ sub close { my $self = shift; undef $self->{fh}; # close the filehandle - delete $self->{fh}; - delete $self->{mode}; + delete $self->{fh}; +} + +sub DESTROY +{ + my $self = shift; + undef $self->{fh}; # close the filehandle + delete $self->{fh} if $self->{fh}; } # log something in the system log @@ -176,10 +181,8 @@ sub Log $log->writeunix($t, join('^', $t, @_) ); } -sub DESTROY # catch undefs and do what is required further down the tree +sub Logclose { - my $self = shift; - DXDebug::dbg("dxlog", "closing $self->{fn}\n"); - undef $self->{fh} if defined $self->{fh}; -} + $log->close(); +} 1;